Skip to content

Conversation

@lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Dec 15, 2025

What problem does this PR solve?

Issue Number: Close #65045 Ref #64938

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2025
@tiprow
Copy link

tiprow bot commented Dec 15, 2025

Hi @lhy1024. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lhy1024 lhy1024 changed the title update pd client and client go *: update pd client and client go Dec 15, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-15 12:51:13.651316755 +0000 UTC m=+1477418.465094327: ☑️ agreed by lcwangchao.
  • 2025-12-15 13:34:37.828319559 +0000 UTC m=+1480022.642097132: ☑️ agreed by cfzjywxk.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 15, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 15, 2025

@lhy1024: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cfzjywxk
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 15, 2025
@cfzjywxk
Copy link
Contributor

/retest

4 similar comments
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 15, 2025

/retest

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 15, 2025

/retest

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 15, 2025

/retest

@lance6716
Copy link
Contributor

/retest

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 16, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2025
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 16, 2025

/retest

1 similar comment
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 16, 2025

/retest

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.2263%. Comparing base (69fb8db) to head (cbd53c7).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #65044        +/-   ##
================================================
+ Coverage   70.8914%   71.2263%   +0.3348%     
================================================
  Files          1889       1914        +25     
  Lines        516117     516840       +723     
================================================
+ Hits         365883     368126      +2243     
+ Misses       125801     124310      -1491     
+ Partials      24433      24404        -29     
Flag Coverage Δ
integration 47.9920% <0.0000%> (-0.1509%) ⬇️
unit 65.9709% <0.0000%> (+0.3146%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 59.5211% <ø> (+0.1609%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 16, 2025

/retest

1 similar comment
@cfzjywxk
Copy link
Contributor

/retest

@lcwangchao
Copy link
Collaborator

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025
@purelind
Copy link
Contributor

/test unit-test

@tiprow
Copy link

tiprow bot commented Dec 17, 2025

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 17, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 524a282 into pingcap:master Dec 17, 2025
29 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #65091.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 17, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update pd client and client go

6 participants