Skip to content

lightning: refactor and add import into checkpoint controller #65241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 15 commits into from
Dec 29, 2025
Merged

lightning: refactor and add import into checkpoint controller #65241

ti-chi-bot merged 15 commits into from
Dec 29, 2025

Conversation

@GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Dec 24, 2025

What problem does this PR solve?

Issue Number: ref #65092

Problem Summary:

  • refactor and add import into checkpoint controller

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 24, 2025
@tiprow
Copy link

tiprow bot commented Dec 24, 2025

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Dec 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 31.48936% with 161 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.5316%. Comparing base (a7bc5df) to head (6df6707).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #65241        +/-   ##
================================================
- Coverage   70.7599%   69.5316%   -1.2284%     
================================================
  Files          1902       1904         +2     
  Lines        519008     520366      +1358     
================================================
- Hits         367250     361819      -5431     
- Misses       127206     135018      +7812     
+ Partials      24552      23529      -1023
Flag Coverage Δ
integration 44.2371% <31.4893%> (-3.9412%) ⬇️
unit 66.1019% <0.0000%> (+0.5587%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 38.6051% <ø> (-19.7182%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 27, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 27, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 27, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 27, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 27, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 27, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 27, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 27, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 27, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 27, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 29, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 29, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

joechenrh
joechenrh approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@joechenrh joechenrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 29, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 29, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-29 07:10:01.928897056 +0000 UTC m=+2666546.742674618: ☑️ agreed by joechenrh.
  • 2025-12-29 09:01:18.406045639 +0000 UTC m=+1634.224354071: ☑️ agreed by D3Hunter.

Benjamin2037
Benjamin2037 approved these changes Dec 29, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 29, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 29, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yudongusa
yudongusa approved these changes Dec 29, 2025
View reviewed changes
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open a document PR.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, joechenrh, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 29, 2025
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Dec 29, 2025

/retest

@tiprow
Copy link

tiprow bot commented Dec 29, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit b7bfd6c into pingcap:master Dec 29, 2025
28 checks passed
Reminiscent pushed a commit to Reminiscent/tidb that referenced this pull request Jan 14, 2026
@GMHDBJD @Reminiscent
lightning: refactor and add import into checkpoint controller (pingca…
05864b6 
…p#65241)

ref pingcap#65092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@joechenrh joechenrh joechenrh approved these changes

+1 more reviewer

@yudongusa yudongusa yudongusa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GMHDBJD @D3Hunter @Benjamin2037 @joechenrh @yudongusa