-
Notifications
You must be signed in to change notification settings - Fork 6.1k
expression: lazy init bufAllocator in baseBuiltinFunc
#65244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: lazy init bufAllocator in baseBuiltinFunc
#65244
Conversation
Signed-off-by: xufei <[email protected]>
|
Hi @windtalker. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65244 +/- ##
================================================
- Coverage 70.7643% 68.6241% -2.1402%
================================================
Files 1901 1880 -21
Lines 518640 512244 -6396
================================================
- Hits 367012 351523 -15489
- Misses 127111 138363 +11252
+ Partials 24517 22358 -2159
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: xufei <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
|
/ok-to-test |
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
|
/test unit-test |
|
/test pull-unit-test-next-gen |
|
@windtalker: The specified target(s) for
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@windtalker: The specified target(s) for
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-integration-e2e-test |
|
@windtalker: The specified target(s) for
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
|
@windtalker: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/test mysql-test |
|
@windtalker: The specified target(s) for
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #65003
Problem Summary:
What changed and how does it work?
bufAllocatoris only used inVecEvalmode, however, currently, TiDB will always initbufAllocatorwhen construct abaseBuiltinFunc. Although we can assume that almost all thebaseBuiltinFuncshould support vec evaluation, some code path just does not useVecEvalmode, for example:tidb/pkg/executor/insert_common.go
Line 221 in 7dea15e
For the pure insert workload described in #65003
Before this pr, the heap profile in alloc_objects space

After this pr, the heap profile in alloc_objects space

As it shows,
expression.newLocalColumnPooldisappears completely, which mean we save8.32%allocations.Check List
Tests
run the workload in planner: optimize the optimizer's CPU and memory usage for
INSERT ... ON DUPLICATE KEY UPDATEstatements #65003, and all the existing test will cover the code pathSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.