-
Notifications
You must be signed in to change notification settings - Fork 6.1k
bazel: use bazel to run failpoint #65251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
|
@hawkingrei: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Weizhen Wang <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65251 +/- ##
================================================
- Coverage 70.7643% 68.8451% -1.9193%
================================================
Files 1901 1880 -21
Lines 518640 514192 -4448
================================================
- Hits 367012 353996 -13016
- Misses 127111 137806 +10695
+ Partials 24517 22390 -2127
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
lance6716
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what problem this PR solves?
I have updated the PR description. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
Currently, each
go installwastes time downloading dependencies and compiling them. Instead, we can directly rely on Bazel's cache to get the job done.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.