dumpling/dump: Fallback to LOCK TABLES when FTWRL is stuck due to upstream operations #65273

seagel · 2025-12-25T23:39:51Z

What problem does this PR solve?

Issue Number: close #56838

Problem Summary:

What changed and how does it work?

Added a 5-second context timeout to FTWRL execution. Triggers automatic fallback to LOCK TABLES if the timeout is reached.
Added unit test to verify the fallback logic during slow operation.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…tream operations for a certain time threshold Signed-off-by: seagel <mehta.somesh636@gmail.com>

ti-chi-bot · 2025-12-25T23:40:01Z

Hi @seagel. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-12-25T23:40:01Z

Welcome @seagel!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/tidb. 😃

tiprow · 2025-12-25T23:40:11Z

Hi @seagel. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lance6716 · 2025-12-26T00:57:36Z

/ok-to-test

lance6716 · 2025-12-26T01:10:04Z

dumpling/export/dump_test.go

 }

+func TestResolveAutoConsistencyFallback(t *testing.T) {
+	db, mock, err := sqlmock.New()


CI found db is not closed after test finished

codecov · 2025-12-26T01:18:49Z

Codecov Report

❌ Patch coverage is 41.04683% with 214 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.7576%. Comparing base (2774ccb) to head (b43e37d).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #65273        +/-   ##
================================================
+ Coverage   70.7352%   70.7576%   +0.0224%     
================================================
  Files          1901       1901                
  Lines        518630     518864       +234     
================================================
+ Hits         366854     367136       +282     
+ Misses       127226     127175        -51     
- Partials      24550      24553         +3

Flag	Coverage Δ
integration	`47.7827% <41.0468%> (-0.3976%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8611% <ø> (-0.0089%)`	⬇️
parser	`∅ <ø> (∅)`
br	`57.9319% <0.0000%> (-0.3003%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…64003) close pingcap#62854

…around OOM (pingcap#65265) ref pingcap#65192

ref pingcap#55231

…ingcap#65177) close pingcap#65176

…cap#65264) close pingcap#65145

close pingcap#65275

ref pingcap#65281

…id block (pingcap#65283) ref pingcap#56556

…ingcap#65284) close pingcap#65221

close pingcap#65224

ref pingcap#65092

…ap#65286) close pingcap#65227

ref pingcap#64938

) ref pingcap#65003

close pingcap#65261

ref pingcap#61702, ref pingcap#64911

ti-chi-bot · 2025-12-27T18:45:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037, fixdb, xuhuaiyu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiprow · 2025-12-27T18:57:17Z

@seagel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	`b43e37d`	link	true	`/test fast_test_tiprow`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot · 2025-12-27T18:57:30Z

@seagel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-error-log-review	`b43e37d`	link	false	`/test pull-error-log-review`
pull-unit-test-next-gen	`b43e37d`	link	true	`/test pull-unit-test-next-gen`
pull-unit-test-ddlv1	`b43e37d`	link	true	`/test pull-unit-test-ddlv1`
idc-jenkins-ci-tidb/unit-test	`b43e37d`	link	true	`/test unit-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dumpling/dump: Fallback to LOCK TABLES when FTWRL is stuck due to ups…

849671e

…tream operations for a certain time threshold Signed-off-by: seagel <mehta.somesh636@gmail.com>

ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 25, 2025

ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Dec 26, 2025

lance6716 reviewed Dec 26, 2025

View reviewed changes

xzhangxian1008 and others added 11 commits December 27, 2025 10:38

executor: prealloc memory before calling AppendCellNTimes (pingcap#…

86bce5d

…64003) close pingcap#62854

dxf: separate runtime slots(concurrency) out of required slot to work…

33804b5

…around OOM (pingcap#65265) ref pingcap#65192

planner: move MaxMinEliminator to rule package (pingcap#65272)

91aea70

ref pingcap#55231

lightning: optimize forceTableSplitRange and skip for small tables (p…

7e62ec5

…ingcap#65177) close pingcap#65176

planner: derivePathStatsAndTryHeuristics can keep more MPP task (ping…

5a80266

…cap#65264) close pingcap#65145

parser: redact azure/azblob url (pingcap#65274)

1d11693

close pingcap#65275

unistore: unistore supports to return commit timestamp (pingcap#65282)

07c605f

ref pingcap#65281

test: avoid to query DNS and port name for lsof in run-test.sh to avo…

b767cea

…id block (pingcap#65283) ref pingcap#56556

planner: fix the flaky test TestInstancePlanCacheConcurrencySysbench (p…

7200867

…ingcap#65284) close pingcap#65221

lightning: skip TestLocalTempKVDirCheckBasic in nextgen (pingcap#65287)

3335791

close pingcap#65224

lightning: add import into checkpoint implementation (pingcap#65184)

55b264d

ref pingcap#65092

qw4990 and others added 5 commits December 27, 2025 10:38

planner: simplify TestBatchDropBindings to make it more stable (pingc…

c8dbb6d

…ap#65286) close pingcap#65227

ddl: fix affinity idempotency problem (pingcap#65291)

75a1a76

ref pingcap#64938

expression: lazy init bufAllocator in baseBuiltinFunc (pingcap#65244

3414be5

) ref pingcap#65003

storage: fix reader error when seeking to end (pingcap#65262)

03a554a

close pingcap#65261

addindex: remove reader ration when using global sort (pingcap#65111)

b43e37d

ref pingcap#61702, ref pingcap#64911

ti-chi-bot bot added sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2025

seagel closed this Dec 27, 2025

seagel mentioned this pull request Dec 27, 2025

dumpling/dump: Fallback to LOCK TABLES when FTWRL is stuck #65303

Open

13 tasks

seagel deleted the third branch December 27, 2025 23:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dumpling/dump: Fallback to LOCK TABLES when FTWRL is stuck due to upstream operations #65273

dumpling/dump: Fallback to LOCK TABLES when FTWRL is stuck due to upstream operations #65273

Uh oh!

seagel commented Dec 25, 2025 •

edited by lance6716

Loading

Uh oh!

ti-chi-bot bot commented Dec 25, 2025

Uh oh!

ti-chi-bot bot commented Dec 25, 2025

Uh oh!

tiprow bot commented Dec 25, 2025

Uh oh!

lance6716 commented Dec 26, 2025

Uh oh!

lance6716 Dec 26, 2025

Uh oh!

codecov bot commented Dec 26, 2025 •

edited

Loading

Uh oh!

ti-chi-bot bot commented Dec 27, 2025

Uh oh!

tiprow bot commented Dec 27, 2025

Uh oh!

ti-chi-bot bot commented Dec 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

dumpling/dump: Fallback to LOCK TABLES when FTWRL is stuck due to upstream operations #65273

dumpling/dump: Fallback to LOCK TABLES when FTWRL is stuck due to upstream operations #65273

Uh oh!

Conversation

seagel commented Dec 25, 2025 • edited by lance6716 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Dec 25, 2025

Uh oh!

ti-chi-bot bot commented Dec 25, 2025

Uh oh!

tiprow bot commented Dec 25, 2025

Uh oh!

lance6716 commented Dec 26, 2025

Uh oh!

lance6716 Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ti-chi-bot bot commented Dec 27, 2025

Uh oh!

tiprow bot commented Dec 27, 2025

Uh oh!

ti-chi-bot bot commented Dec 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

seagel commented Dec 25, 2025 •

edited by lance6716

Loading

codecov bot commented Dec 26, 2025 •

edited

Loading