Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #65290

Signed-off-by: Juncen Yu yujuncen@pingcap.com

What problem does this PR solve?

Issue Number: ref #65288, ref #64814

Problem Summary:
See the issue.

What changed and how does it work?

Add batch#, region# and so on to track restoring SST.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 31, 2025
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Dec 31, 2025
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 31, 2025
@ti-chi-bot
Copy link
Member Author

@YuJuncen This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 31, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2025
commit 0ee3196
Author: Juncen Yu <yujuncen@pingcap.com>
Date:   Wed Dec 31 15:11:49 2025 +0800

    fix typo

    Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

commit ce8741b
Author: Juncen Yu <yujuncen@pingcap.com>
Date:   Fri Dec 26 16:14:55 2025 +0800

    br: enhance logging and metrics for SST and restore processes

    Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@YuJuncen YuJuncen force-pushed the cherry-pick-65290-to-release-8.5 branch from 76479f0 to e898d35 Compare January 1, 2026 16:13
@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

❌ Patch coverage is 90.54054% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@9b0a76f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #65370   +/-   ##
================================================
  Coverage               ?   73.3949%           
================================================
  Files                  ?       1680           
  Lines                  ?     470073           
  Branches               ?          0           
================================================
  Hits                   ?     345010           
  Misses                 ?     102279           
  Partials               ?      22784           
Flag Coverage Δ
integration 51.0355% <83.7837%> (?)
unit 65.0964% <20.2702%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 64.2037% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmmaDuDu
Copy link

EmmaDuDu commented Jan 4, 2026

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 5, 2026
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2026

@RidRisR: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, RidRisR, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-07 04:00:53.263570712 +0000 UTC m=+761209.081879144: ☑️ agreed by YuJuncen.
  • 2026-01-07 04:19:36.665103015 +0000 UTC m=+762332.483411447: ☑️ agreed by BornChanger.

@YuJuncen
Copy link
Contributor

YuJuncen commented Jan 7, 2026

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2026
@EmmaDuDu
Copy link

EmmaDuDu commented Jan 7, 2026

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jan 7, 2026

@EmmaDuDu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmmaDuDu
Copy link

EmmaDuDu commented Jan 7, 2026

/retest

2 similar comments
@YuJuncen
Copy link
Contributor

YuJuncen commented Jan 7, 2026

/retest

@YuJuncen
Copy link
Contributor

YuJuncen commented Jan 7, 2026

/retest

@EmmaDuDu
Copy link

EmmaDuDu commented Jan 8, 2026

/test unit-test

@tiprow
Copy link

tiprow bot commented Jan 8, 2026

@EmmaDuDu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 2f33c06 into pingcap:release-8.5 Jan 8, 2026
32 of 40 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-65290-to-release-8.5 branch January 8, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants