-
Notifications
You must be signed in to change notification settings - Fork 6.1k
br: fix bug file-not-found error for gcs (#65058) #65404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix bug file-not-found error for gcs (#65058) #65404
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #65404 +/- ##
================================================
Coverage ? 73.2526%
================================================
Files ? 1680
Lines ? 469212
Branches ? 0
================================================
Hits ? 343710
Misses ? 102651
Partials ? 22851
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
/retest |
|
/test unit-test |
|
@EmmaDuDu: The specified target(s) for
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@YuJuncen: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #65058
What problem does this PR solve?
Issue Number: close #63567
Problem Summary: retry br log truncate, it may fail forever, only for gcs storage
What changed and how does it work?
deal with file-not-exist situation correctly as it has been deleted which should return no-error.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.