Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #65058

What problem does this PR solve?

Issue Number: close #63567

Problem Summary: retry br log truncate, it may fail forever, only for gcs storage

What changed and how does it work?

deal with file-not-exist situation correctly as it has been deleted which should return no-error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5@2675484). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #65404   +/-   ##
================================================
  Coverage               ?   73.2526%           
================================================
  Files                  ?       1680           
  Lines                  ?     469212           
  Branches               ?          0           
================================================
  Hits                   ?     343710           
  Misses                 ?     102651           
  Partials               ?      22851           
Flag Coverage Δ
integration 51.1459% <20.0000%> (?)
unit 64.9442% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.7044% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 5, 2026
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2026
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 6, 2026
@EmmaDuDu
Copy link

EmmaDuDu commented Jan 7, 2026

/retest

@EmmaDuDu
Copy link

EmmaDuDu commented Jan 7, 2026

/test unit-test

@tiprow
Copy link

tiprow bot commented Jan 7, 2026

@EmmaDuDu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow_for_release

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2026

@YuJuncen: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 7, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 7, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-06 07:22:09.393308787 +0000 UTC m=+686885.211617209: ☑️ agreed by YuJuncen.
  • 2026-01-07 04:19:05.432994564 +0000 UTC m=+762301.251303016: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit c7e66ba into pingcap:release-8.5 Jan 7, 2026
28 of 36 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-65058-to-release-8.5 branch January 7, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants