-
Notifications
You must be signed in to change notification settings - Fork 6.1k
br: load necessary db infos for backup and restore (#64982) #65741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5-20260116-v8.5.5
Are you sure you want to change the base?
br: load necessary db infos for backup and restore (#64982) #65741
Conversation
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
|
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5-20260116-v8.5.5 #65741 +/- ##
================================================================
Coverage ? 73.2373%
================================================================
Files ? 1683
Lines ? 469351
Branches ? 0
================================================================
Hits ? 343740
Misses ? 102737
Partials ? 22874
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
D3Hunter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
| .PHONY: tools/bin/revive | ||
| tools/bin/revive: | ||
| GOBIN=$(shell pwd)/tools/bin $(GO) install github.com/mgechev/revive@v1.2.1 | ||
| @test -x $@ || GOBIN=$(shell pwd)/tools/bin $(GO) install github.com/mgechev/revive@v1.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change it
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: D3Hunter The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@YuJuncen: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #64982
What problem does this PR solve?
Issue Number: close #64833
Problem Summary:
See the issue.
What changed and how does it work?
Added a filter to
loader, which allows the caller to load a subset of tables only.This pick is finished by
codex.__agent_task.md
# BackgroundWe just merged
9c0773b008bd015842689b5fc31d91ab9842801fto master. But, (how sadly!) it seems inmasterbranch there is a refactor over DDL has been performed, the folder structure of DDL subsystem is fully different with master. . We cannot trivially usegit cherry-pickto pick it back to release-8.5.However, me, a bad-luck engineer. Have been required to pick it back to release-8.5. I need your help.
Would you finish this cherry-pick for me with the following steps? Also don't forget to fill the document during working.
Workflow
git show 9c0773b008bd015842689b5fc31d91ab9842801fand the folder structure. Determine patches that can be trivially applied. Apply them then commit them. You don't need to pick patches ofgo.{mod,sum}or*.{bzl,bazel}.Describe parts you have applied here:
br/pkg/utils/schema.go:UnquoteName(used by restore schema filtering).br/tests/br_tidb_placement_policy/run.shtoexport BR_LOG_TO_TERM=1before restore, matching upstream.meta.Reader.IterDatabases+meta.Mutator.IterDatabases(and a unit test) to allow iterating DB infos without materializing the full list.pkg/meta/metadef/db.gowith helpers to identify system/memory/BR-temporary DBs, matching upstream definitions.Commit it (but don't commit this file), let's continue.
Describe what you did here:
pkg/infoschema/issyncer.Filter(ported from upstream) andbr/pkg/gluetidb.NewInfoSchemaFilter.pkg/sessiondomain creation to accept a filter (GetOrCreateDomainWithFilter), passing it intopkg/domain.NewDomain.pkg/domain/domain.goschema loading:meta.Reader.IterDatabasesand only load selected schemas;infoschema.Builder.SetSchemaVersion.Commit it, let's continue.
make server,make build_brandmake lintall returns zero.Commit it (if any), let's continue.
git range-diffto generate a patch-of-patch between your modification and the origin patch (9c0773b008bd015842689b5fc31d91ab9842801f).Fill your
git range-diffcommand here:# git range-diff --no-color --creation-factor=90 9c0773b008bd015842689b5fc31d91ab9842801f^..9c0773b008bd015842689b5fc31d91ab9842801f 1fa258b833..HEADSave its output to
__agent_output.txt.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.