Skip to content

tests/docker: update TiDB stack/TiFlash image registries and sanitize branch-tag variables#10721

Open
Copilot wants to merge 3 commits intofeature/release-8.5-materialized-viewfrom
copilot/update-image-repositories
Open

tests/docker: update TiDB stack/TiFlash image registries and sanitize branch-tag variables#10721
Copilot wants to merge 3 commits intofeature/release-8.5-materialized-viewfrom
copilot/update-image-repositories

Conversation

Copy link

Copilot AI commented Feb 13, 2026

What problem does this PR solve?

Problem Summary:

Docker test compose files needed image-tag-safe variable handling and registry migration to new GAR paths. Branch/tag values containing / could produce invalid image tags, and only part of the compose variants had been updated initially.

What is changed and how it works?

tests/docker: update image repos and sanitize branch tags
tests/docker: align cluster variants and tiflash image repo
  • Registry migration for all cluster variants

    • Updated:
      • tests/docker/cluster.yaml
      • tests/docker/cluster_new_collation.yaml
      • tests/docker/cluster_disable_new_collation.yaml
      • tests/docker/cluster_tidb_fail_point.yaml
    • Replaced image repositories with:
      • PD: us-docker.pkg.dev/pingcap-testing-account/hub/tikv/pd/image
      • TiKV: us-docker.pkg.dev/pingcap-testing-account/hub/tikv/tikv/image
      • TiDB: us-docker.pkg.dev/pingcap-testing-account/hub/pingcap/tidb/images/tidb-server
  • TiFlash tagged image repository update

    • Updated tests/docker/tiflash-tagged-image.yaml to:
      • us-docker.pkg.dev/pingcap-testing-account/hub/pingcap/tiflash/image:${TAG:-master}
  • Variable sanitization for image tag compatibility

    • Added / -> - normalization for:
      • PD_BRANCH, TIKV_BRANCH, TIDB_BRANCH in tests/docker/run.sh and tests/docker/util.sh
      • TAG in tests/docker/run.sh
    • This ensures branch/tag-derived image tags are valid Docker tags.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual validation:

  • Ran docker compose ... config checks for:
    • cluster.yaml
    • cluster_new_collation.yaml
    • cluster_disable_new_collation.yaml
    • cluster_tidb_fail_point.yaml
    • each combined with tiflash-tagged-image.yaml
  • Verified resolved images use new GAR repositories.
  • Verified slash-containing branch/tag inputs are normalized to dash in rendered image tags.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 13, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 13, 2026

Hi @Copilot. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo wuhuizuo changed the title [WIP] Update image repositories and process branch variables tests: update image repositories and process branch variables Feb 13, 2026
Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2026
@wuhuizuo wuhuizuo marked this pull request as ready for review February 13, 2026 03:15
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2026
Copilot AI changed the title tests: update image repositories and process branch variables tests/docker: update TiDB stack image registries and sanitize branch tags Feb 13, 2026
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 13, 2026
Copilot AI requested a review from wuhuizuo February 13, 2026 03:15
@wuhuizuo
Copy link
Contributor

/test ?

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 13, 2026

@wuhuizuo: The following commands are available to trigger required jobs:

/test pull-integration-test
/test pull-unit-test

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

/test pull-integration-test

@wuhuizuo
Copy link
Contributor

/test pull-unit-test

Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 13, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xzhangxian1008
Once this PR has been reviewed and has the lgtm label, please assign jayson-huang for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-13 03:17:30.993497928 +0000 UTC m=+161204.073488623: ☑️ agreed by xzhangxian1008.

@wuhuizuo wuhuizuo mentioned this pull request Feb 13, 2026
12 tasks
@wuhuizuo
Copy link
Contributor

@copilot also should update the files: tests/docker/cluster*.yaml.
also update file tests/docker/tiflash-tagged-image.yaml with new repo: us-docker.pkg.dev/pingcap-testing-account/hub/pingcap/tiflash/image and deal the var usage.

Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2026
Copy link
Author

Copilot AI commented Feb 13, 2026

@copilot also should update the files: tests/docker/cluster*.yaml.
also update file tests/docker/tiflash-tagged-image.yaml with new repo: `us-docker.pkg.dev/pingcap-testing-account/hub/pingcap/ti...

Done in commit 9308f69.

Updated all tests/docker/cluster*.yaml files to the new pd/tikv/tidb repos, updated tests/docker/tiflash-tagged-image.yaml to us-docker.pkg.dev/pingcap-testing-account/hub/pingcap/tiflash/image, and handled var sanitization by adding TAG / -> - normalization in tests/docker/run.sh.

Copilot AI changed the title tests/docker: update TiDB stack image registries and sanitize branch tags tests/docker: update TiDB stack/TiFlash image registries and sanitize branch-tag variables Feb 13, 2026
@wuhuizuo
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants