tests/docker: update TiDB stack/TiFlash image registries and sanitize branch-tag variables#10721
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
|
/test ? |
|
@wuhuizuo: The following commands are available to trigger required jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-integration-test |
|
/test pull-unit-test |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xzhangxian1008 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@copilot also should update the files: |
Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
Done in commit Updated all |
|
/ok-to-test |
What problem does this PR solve?
Problem Summary:
Docker test compose files needed image-tag-safe variable handling and registry migration to new GAR paths. Branch/tag values containing
/could produce invalid image tags, and only part of the compose variants had been updated initially.What is changed and how it works?
Registry migration for all cluster variants
tests/docker/cluster.yamltests/docker/cluster_new_collation.yamltests/docker/cluster_disable_new_collation.yamltests/docker/cluster_tidb_fail_point.yamlus-docker.pkg.dev/pingcap-testing-account/hub/tikv/pd/imageus-docker.pkg.dev/pingcap-testing-account/hub/tikv/tikv/imageus-docker.pkg.dev/pingcap-testing-account/hub/pingcap/tidb/images/tidb-serverTiFlash tagged image repository update
tests/docker/tiflash-tagged-image.yamlto:us-docker.pkg.dev/pingcap-testing-account/hub/pingcap/tiflash/image:${TAG:-master}Variable sanitization for image tag compatibility
/ -> -normalization for:PD_BRANCH,TIKV_BRANCH,TIDB_BRANCHintests/docker/run.shandtests/docker/util.shTAGintests/docker/run.shCheck List
Tests
Manual validation:
docker compose ... configchecks for:cluster.yamlcluster_new_collation.yamlcluster_disable_new_collation.yamlcluster_tidb_fail_point.yamltiflash-tagged-image.yamlSide effects
Documentation
Release note
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.