Skip to content

Comments

Support spark3.4#2808

Merged
ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom
comnetwork:spark_3_4
Feb 27, 2025
Merged

Support spark3.4#2808
ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom
comnetwork:spark_3_4

Conversation

@comnetwork
Copy link
Contributor

What problem does this PR solve?

support Spark3.4

What is changed and how it works?

add Spark3.4 Support

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

@sre-bot
Copy link
Contributor

sre-bot commented Feb 21, 2025

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2025

Welcome @comnetwork! It looks like this is your first PR to pingcap/tispark 🎉

@ti-chi-bot ti-chi-bot bot added the size/XXL label Feb 21, 2025
@comnetwork
Copy link
Contributor Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@comnetwork comnetwork changed the title support Spark3.4 Support spark3.4 Feb 21, 2025
@iamxy iamxy added the lgtm label Feb 21, 2025
@ti-chi-bot ti-chi-bot bot removed the lgtm label Feb 21, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2025

@iamxy: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

Details

In response to adding label named lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@iamxy iamxy added the approved label Feb 21, 2025
@ti-chi-bot ti-chi-bot bot removed the approved label Feb 21, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2025

@iamxy: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

Details

In response to adding label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2025

@iamxy: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

Details

In response to adding label named lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2025

@iamxy: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

Details

In response to adding label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@iamxy
Copy link
Member

iamxy commented Feb 21, 2025

/lgtm
/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 21, 2025

@iamxy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

/run-all-tests

@comnetwork
Copy link
Contributor Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5 profile=spark-3.1

@comnetwork
Copy link
Contributor Author

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5 profile=spark-3.2

@shiyuhang0
Copy link
Member

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@shiyuhang0
Copy link
Member

/run-all-tests tidb=release-6.5 tikv=release-6.5 pd=release-6.5

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamxy, shiyuhang0, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 07:36:32.395991053 +0000 UTC m=+514140.349149317: ☑️ agreed by shiyuhang0.
  • 2025-02-27 08:44:33.746477784 +0000 UTC m=+518221.699636050: ☑️ agreed by zhangyangyu.

@ti-chi-bot ti-chi-bot bot merged commit 4395cd4 into pingcap:master Feb 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants