cluster: check both SELinux status and config#2496
Open
dveeden wants to merge 1 commit intopingcap:masterfrom
Open
cluster: check both SELinux status and config#2496dveeden wants to merge 1 commit intopingcap:masterfrom
dveeden wants to merge 1 commit intopingcap:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
breezewish
approved these changes
Feb 5, 2025
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently
tiup cluster checkonly checks if SELinux is configured to be disabled. It does not check the current status.What is changed and how it works?
This now adds a second check (
CheckSELinuxStatus) and renames the first one toCheckSELinuxConf.Another option would be to roll both into
CheckSELinuxCheck List
Tests
Code changes
Release notes: