Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Please upload reports for the commit 758d560 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #2596 +/- ##
==========================================
- Coverage 40.97% 40.60% -0.37%
==========================================
Files 363 363
Lines 37683 38216 +533
==========================================
+ Hits 15440 15517 +77
- Misses 20327 20781 +454
- Partials 1916 1918 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dveeden: GitHub didn't allow me to request PR reviews from the following users: ottok. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
close #2588
What is changed and how it works?
Replaces usql (which brings many indirect dependencies) with printing a line that prints the commandline options for MySQL Client.
This fixes:
tiup clientfor playground having a different behavior and experience as atiup clusteror k8s deployed cluster.We could:
mysqlCheck List
Tests
Code changes
Side effects
Related changes
Release notes: