Skip to content

cluster: unify default tiflash logger size/count with doc#2683

Open
fzzf678 wants to merge 1 commit intopingcap:masterfrom
fzzf678:unify_logger_size_count
Open

cluster: unify default tiflash logger size/count with doc#2683
fzzf678 wants to merge 1 commit intopingcap:masterfrom
fzzf678:unify_logger_size_count

Conversation

@fzzf678
Copy link

@fzzf678 fzzf678 commented Feb 14, 2026

What problem does this PR solve?

In the doc https://docs.pingcap.com/tidb/stable/tiflash-configuration/#logger, the logger.size and logger.count should be 100M and 10, this is not consistent with the default value in the tiup cluster.

close #2684

What is changed and how it works?

Unify the logger size and count with doc

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from srstack February 14, 2026 07:09
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap-cla-assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.35%. Comparing base (c567110) to head (d97c3c5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
- Coverage   42.37%   42.35%   -0.01%     
==========================================
  Files         424      424              
  Lines       47043    47043              
==========================================
- Hits        19930    19925       -5     
- Misses      24426    24429       +3     
- Partials     2687     2689       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default values of logger.size and logger.count for the TiFlash configuration file parameters are incorrect.

2 participants