cluster: unify default tiflash logger size/count with doc#2683
cluster: unify default tiflash logger size/count with doc#2683fzzf678 wants to merge 1 commit intopingcap:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2683 +/- ##
==========================================
- Coverage 42.37% 42.35% -0.01%
==========================================
Files 424 424
Lines 47043 47043
==========================================
- Hits 19930 19925 -5
- Misses 24426 24429 +3
- Partials 2687 2689 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What problem does this PR solve?
In the doc https://docs.pingcap.com/tidb/stable/tiflash-configuration/#logger, the
logger.sizeandlogger.countshould be100Mand10, this is not consistent with the default value in the tiup cluster.close #2684
What is changed and how it works?
Unify the logger size and count with doc
Check List
Tests
Code changes
Side effects
Related changes
Release notes: