Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: eb2349d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdates Effect-related library versions across the project and adapts two TypeScript files to API changes in the updated libraries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
More templates
commit: |
📦 Bundle size comparison
|
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Greptile SummaryThis PR updates Confidence Score: 5/5Safe to merge — changes are a straightforward dependency bump with a small, targeted API fix and one minor type annotation concern. All remaining findings are P2 style suggestions. The packages/uploadthing/src/effect-platform.ts — the Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["createRouteHandler(opts)"] --> B["createRequestHandler (Effect.runSync)"]
B --> C["HttpRouter.provideServiceEffect\n(binds AdapterArguments → HttpServerRequest)"]
C --> D["Effect.provide(Layer.setConfigProvider)"]
D --> E["HttpApp.Default<unknown, HttpClient.HttpClient>"]
E --> F["HttpRouter.mountApp('/api/uploadthing', uploadthingRouter)"]
F --> G["HttpRouter with CORS middleware"]
G --> H["HttpServer.serve → NodeRuntime.runMain"]
Reviews (1): Last reviewed commit: "chore: remove unused effect import" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| */ | ||
| config?: Omit<RouteHandlerConfig, "fetch" | "logLevel">; | ||
| }) => { | ||
| }): HttpApp.Default<unknown, HttpClient.HttpClient> => { |
There was a problem hiding this comment.
unknown error channel may be too permissive
HttpApp.Default<unknown, HttpClient.HttpClient> uses unknown for the error channel (E). In Effect, HttpApp.Default is typically Effect<ServerResponse, E, R | HttpServerRequest>, and handlers that have fully dealt with their errors conventionally use never for E. Leaving it as unknown means consumers of this function cannot rely on the type system to tell them the error channel is handled, and composition with other Effect combinators may produce unexpected widened error types.
| }): HttpApp.Default<unknown, HttpClient.HttpClient> => { | |
| }): HttpApp.Default<never, HttpClient.HttpClient> => { |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
2 participants
Summary
effectand all@effect/*dependencies used in the workspace to the latest published versionspnpm-lock.yamlafter the recursive dependency updateuploadthing/effect-platformadapter typing with the upgraded Effect platform APIs and update the backend adapter example to mount it as an appTesting
pnpm --filter @uploadthing/shared testpnpm --filter uploadthing buildpnpm --filter uploadthing typecheckpnpm --filter @example/backend-adapters-server buildpnpm exec playwright install chromiumpnpm --filter uploadthing testSummary by CodeRabbit
Chores
Refactor