Add installation instructions to the app.R script#82
Open
zeehio wants to merge 3 commits intopinin4fjords:developfrom
Open
Add installation instructions to the app.R script#82zeehio wants to merge 3 commits intopinin4fjords:developfrom
zeehio wants to merge 3 commits intopinin4fjords:developfrom
Conversation
If the output directory is given to a user who doesn't have shinyngs installed, having these instructions helps a lot.
pinin4fjords
requested changes
Oct 31, 2025
Owner
pinin4fjords
left a comment
pinin4fjords
left a comment
There was a problem hiding this comment.
I'd rather not embed docs in code, the right way is too dependent on context.
Can we just link to https://github.com/pinin4fjords/shinyngs?tab=readme-ov-file#installation?
Updated installation instructions for shinyngs package.
Contributor
Author
|
Done :-) |
pinin4fjords
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the output directory is given to a user who doesn't have shinyngs installed, having these instructions helps a lot.
This PR comes from the nf-core hackathon
@suzannejin
@SusiJo