Support exclude_samples_col/exclude_samples_values in contrast validation#87
Open
pinin4fjords wants to merge 1 commit intodevelopfrom
Open
Support exclude_samples_col/exclude_samples_values in contrast validation#87pinin4fjords wants to merge 1 commit intodevelopfrom
pinin4fjords wants to merge 1 commit intodevelopfrom
Conversation
…tion - Filter samples per-contrast before building the design matrix and checking full rank, aligning with differentialabundance pipeline behaviour - Add validate_design parameter to disable design matrix checks when not needed Fixes #86 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
pinin4fjords
force-pushed
the
feature/exclude-samples-validation
branch
from
2a3d9fc to
c921f15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude_samples_colandexclude_samples_valuescan be used to exclude samples for specific contrastsvalidate_designparameter toread_contrasts()to disable design matrix checks when not neededFixes #86
Test plan
exclude_samples_colandexclude_samples_valuesvalidate_design = FALSEskips design matrix checks🤖 Generated with Claude Code