Skip to content

[#12455] Update s3 client error mark #12485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaehong-kim merged 1 commit into from
May 26, 2025
Merged

[#12455] Update s3 client error mark #12485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agent-module/agent/src/main/resources/profiles/local/pinpoint.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ profiler.aws.sdk.s3.enable=true
# Allow profiling status code value.
profiler.aws.sdk.s3.statuscode=true
# Mark error
profiler.aws.sdk.s3.mark.error=true
profiler.aws.sdk.s3.mark.error=false
# Cannot be used with the Apache HttpClient 4.x or JDK HttpURLConnection.
# Use the -Dprofiler.apache.httpclient4.enable=false or -Dprofiler.jdk.http=false setting.

Expand Down
2 changes: 1 addition & 1 deletion agent-module/agent/src/main/resources/profiles/release/pinpoint.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ profiler.aws.sdk.s3.enable=true
# Allow profiling status code value.
profiler.aws.sdk.s3.statuscode=true
# Mark error
profiler.aws.sdk.s3.mark.error=true
profiler.aws.sdk.s3.mark.error=false
# Cannot be used with the Apache HttpClient 4.x or JDK HttpURLConnection.
# Use the -Dprofiler.apache.httpclient4.enable=false or -Dprofiler.jdk.http=false setting.

Expand Down
2 changes: 1 addition & 1 deletion ...s-sdk-s3/src/main/java/com/navercorp/pinpoint/plugin/aws/sdk/s3/AwsSdkS3PluginConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static boolean isStatusCode(ProfilerConfig config) {
}

public static boolean isMarkError(ProfilerConfig config) {
return config.readBoolean("profiler.aws.sdk.s3.mark.error", Boolean.TRUE);
return config.readBoolean("profiler.aws.sdk.s3.mark.error", Boolean.FALSE);
}

public AwsSdkS3PluginConfig(ProfilerConfig config) {
Expand Down