[#noissue] Refactor Application handling to include Service#13414
Merged
emeroad merged 1 commit intopinpoint-apm:masterfrom Feb 20, 2026
Merged
[#noissue] Refactor Application handling to include Service#13414emeroad merged 1 commit intopinpoint-apm:masterfrom
emeroad merged 1 commit intopinpoint-apm:masterfrom
Conversation
emeroad
force-pushed
the
#noissue-back
branch
2 times, most recently
from
58591fd to
5abb5d0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13414 +/- ##
============================================
+ Coverage 33.10% 33.11% +0.01%
- Complexity 10975 10983 +8
============================================
Files 4066 4066
Lines 94350 94387 +37
Branches 9817 9818 +1
============================================
+ Hits 31232 31257 +25
- Misses 60437 60445 +8
- Partials 2681 2685 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emeroad
force-pushed
the
#noissue-back
branch
from
5abb5d0 to
2b63b8d
Compare
emeroad
force-pushed
the
#noissue-back
branch
from
2b63b8d to
2a84725
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way
Applicationobjects are constructed throughout the codebase to consistently include aserviceUid(service unique identifier) parameter. This change impacts many areas, including application creation in controllers, DAOs, mappers, and utility classes. Additionally, dependencies are updated to support the newApplicationFactorysignature, and related code is adjusted for improved clarity and correctness.Refactoring application creation to include
serviceUid:Updated all usages of
ApplicationFactory.createApplicationand directApplicationconstructors to include aserviceUidparameter, typically usingServiceUid.DEFAULT.getUid()or extracting it from relevant objects. This ensures that allApplicationinstances are constructed with a unique service identifier, improving consistency and correctness across the codebase. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Refactored the construction of
Applicationobjects in mappers and processors to extractserviceUidfrom row keys or use defaults as appropriate. [1] [2] [3]Dependency and interface updates:
ApplicationResponseTimeV3ResultExtractorand its usage to depend onApplicationFactoryinstead ofServiceTypeRegistryService, reflecting the new construction pattern forApplicationobjects. [1] [2] [3] [4]Code clarity and correctness improvements:
ServiceandServiceUidwhere necessary to support the new application creation signature. [1] [2] [3]RowFilterby replacing.getName()with.getApplicationName()for correct property access.getSpanApplicationinFilteredMapBuilderfor clarity and to centralize the new application creation logic. [1] [2]These changes collectively ensure that the
serviceUidis consistently handled throughout the application, laying the groundwork for improved identification and management of services.