Skip to content

Comments

[#noissue] Remove unused method from ActiveAgentValidator#13417

Merged
emeroad merged 1 commit intopinpoint-apm:masterfrom
emeroad:#noissue_agentvalidation
Feb 19, 2026
Merged

[#noissue] Remove unused method from ActiveAgentValidator#13417
emeroad merged 1 commit intopinpoint-apm:masterfrom
emeroad:#noissue_agentvalidation

Conversation

@emeroad
Copy link
Member

@emeroad emeroad commented Feb 19, 2026

This pull request simplifies the ActiveAgentValidator interface and its implementation by removing an unused method that checked agent activity across multiple time ranges. This reduces code complexity and potential maintenance overhead.

Removed unused multi-range agent validation:

  • ActiveAgentValidator interface: Removed the isActiveAgent(Application agent, String version, List<Range> ranges) method declaration.
  • DefaultActiveAgentValidator implementation: Removed the corresponding isActiveAgent(Application agent, String version, List<Range> ranges) method implementation.

@sonarqubecloud
Copy link

@emeroad emeroad merged commit 97162a3 into pinpoint-apm:master Feb 19, 2026
4 of 5 checks passed
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.10%. Comparing base (ba3d66e) to head (ccb5407).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #13417   +/-   ##
=========================================
  Coverage     33.10%   33.10%           
  Complexity    10974    10974           
=========================================
  Files          4066     4066           
  Lines         94355    94350    -5     
  Branches       9816     9815    -1     
=========================================
+ Hits          31233    31237    +4     
+ Misses        60440    60430   -10     
- Partials       2682     2683    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emeroad emeroad deleted the #noissue_agentvalidation branch February 20, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant