Skip to content

[#13287] Remove unnecessary comments #13418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minwoo-jung merged 1 commit into from
Feb 19, 2026
+1 −13
Merged

[#13287] Remove unnecessary comments #13418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions batch/src/main/java/com/navercorp/pinpoint/batch/config/BatchInfrastructureConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ public AlarmMessageSender alarmMessageSender(
return new DefaultAlarmMessageSender(mailSender, webhookSender, smsSender);
}

// ---- 기존 XML(applicationContext-batch-common.xml)에 있던 추가 빈들 ----
// 다른 Job들(agentCount, cleanup 등)에서 사용될 수 있으므로 누락 방지 차원에서 등록

@Bean
public ConfigProperties configProperties() {
return new ConfigProperties();
Expand All @@ -151,7 +148,6 @@ public TransactionTemplate transactionTemplate(PlatformTransactionManager transa
return new TransactionTemplate(transactionManager);
}

// - sqlSessionFactory (MyBatis core factory)
@Bean
public FactoryBean<SqlSessionFactory> sqlSessionFactory(
@Qualifier("dataSource") DataSource dataSource,
Expand All @@ -173,15 +169,13 @@ public FactoryBean<SqlSessionFactory> sqlSessionFactory(
return sessionFactoryBean;
}

// - sqlSessionTemplate (if a SqlSessionFactory exists in the context)
@Bean
public SqlSessionTemplate sqlSessionTemplate(
@Qualifier("sqlSessionFactory") SqlSessionFactory sessionFactory) {
return new SqlSessionTemplate(sessionFactory);
}

// - batchSqlSessionTemplate (configured for BATCH executor type)
@Bean(name = "batchSqlSessionTemplate")
@Bean
public SqlSessionTemplate batchSqlSessionTemplate(
@Qualifier("sqlSessionFactory") SqlSessionFactory sessionFactory) {
return new SqlSessionTemplate(sessionFactory, org.apache.ibatis.session.ExecutorType.BATCH);
Expand Down
6 changes: 0 additions & 6 deletions batch/src/main/java/com/navercorp/pinpoint/batch/config/BatchScheduleConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@
import org.springframework.scheduling.config.ScheduledTaskRegistrar;
import org.springframework.scheduling.support.CronTrigger;

/**
* 기존 applicationContext-batch-schedule.xml 대체
*
* Java Configuration 기반 배치 스케줄링 설정
* BatchJavaConfigModule에 의해 조건부 로드됨
*/
@Configuration
@EnableScheduling
public class BatchScheduleConfig implements SchedulingConfigurer {
Expand Down