Skip to content

Refactor: Migrate dynamic profiling endpoints to dedicated router #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashokbytebytego wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: Migrate dynamic profiling endpoints to dedicated router #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/gprofiler/backend/routers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

from backend.routers import (
api_key_routes,
dynamicprofiling,
filters_routes,
flamegraph_routes,
healthcheck_routes,
Expand All @@ -33,6 +34,10 @@
router.include_router(healthcheck_routes.router, prefix="/v2/health_check", tags=["agent"])
router.include_router(flamegraph_routes.router, prefix="/flamegraph", tags=["flamegraph"])
router.include_router(metrics_routes.router, prefix="/metrics", tags=["metrics"])
# Dynamic Profiling - New endpoint (preferred)
router.include_router(dynamicprofiling.router, prefix="/dynamicprofiling", tags=["dynamicprofiling"])
# Dynamic Profiling - Backward compatibility (legacy agents using /metrics prefix)
router.include_router(dynamicprofiling.router, prefix="/metrics", tags=["dynamicprofiling-legacy"])
Copy link

@prashantbytesyntax prashantbytesyntax Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may impact /metrics logic too, can you make sure this test cases is covered

router.include_router(installations_routes.router, prefix="/installations", tags=["app"])
router.include_router(api_key_routes.router, prefix="/api_key", tags=["auth"])
router.include_router(profiles_routes.router, prefix="/v2/profiles", tags=["agent"])
Expand Down
Loading
Loading