client: allow daemon to run as non-root with init-created dirs#121
Merged
krockpot merged 2 commits intopinterest:masterfrom Mar 13, 2026
Merged
client: allow daemon to run as non-root with init-created dirs#121krockpot merged 2 commits intopinterest:masterfrom
krockpot merged 2 commits intopinterest:masterfrom
Conversation
added 2 commits
March 13, 2026 17:34
- chmodIfNeeded: only chmod when current perms differ from desired, avoiding 'operation not permitted' when init container already set correct permissions - ensureDirExists: succeed when path already exists (e.g. created by init) so MkdirAll permission failure does not crash the sidecar - Add table-driven tests for both helpers Made-with: Cursor
…ts in daemon.go Keep chmodIfNeeded/ensureDirExists and use master's error style (%w, lowercase). Made-with: Cursor
xia0pin9
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the Knox client daemon to run as non-root when used as a K8s sidecar with an init container that creates
/var/lib/knoxand sets permissions.Made with Cursor