Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make buildthe compiler complains that it “can’t type check this expression in reasonable time” inObjectiveCInitExtension.swift. I put the expression in an explicitly declared variable to help out the compiler’s tiny brain.testPolymorphicPropWithBoolis failing. Looking at the code, we test that anNSNumberis a bool by comparing itsobjCTypeto the result of@encode(BOOL):However, I’m seeing weird behavior where
@encode(BOOL)is not returningcas Apple documentation says it should:Here is what I was seeing in the debugger:
I am not sure why this is retuning
B, but it seems a safer check would be to compare theobjCTypeofvaluewith theobjCTypeof aNSNumberwe know is created with aBOOL:I added this change to fix the tests.