Skip to content

Pyupgrade to 3.9#620

Merged
jparise merged 9 commits intopinterest:masterfrom
daveisfera:pyupgrade
Feb 5, 2025
Merged

Pyupgrade to 3.9#620
jparise merged 9 commits intopinterest:masterfrom
daveisfera:pyupgrade

Conversation

@daveisfera
Copy link
Contributor

@daveisfera daveisfera commented Nov 26, 2024

Minimum version of 3.9
Add up to 3.13
Build improvements

@daveisfera daveisfera requested a review from a team as a code owner November 26, 2024 04:41
@ikoruk
Copy link

ikoruk commented Jan 27, 2025

Hi @jparise is there any chance of getting this PR reviewed and pushed upstream? It would be nice to use a pymemcache that officially supports the newer Pythons.

@jparise
Copy link
Collaborator

jparise commented Feb 2, 2025

Hi @jparise is there any chance of getting this PR reviewed and pushed upstream? It would be nice to use a pymemcache that officially supports the newer Pythons.

I no longer work at Pinterest or use pymemcache on a regular basis, but I'll try to block out some time soon to help work through the backlog of open pull requests.

This was referenced Feb 2, 2025
@daveisfera
Copy link
Contributor Author

I no longer work at Pinterest or use pymemcache on a regular basis, but I'll try to block out some time soon to help work through the backlog of open pull requests.

Thanks! This should be a really low risk change so hopefully should be an easy one to click merge on

@jparise
Copy link
Collaborator

jparise commented Feb 2, 2025

I no longer work at Pinterest or use pymemcache on a regular basis, but I'll try to block out some time soon to help work through the backlog of open pull requests.

Thanks! This should be a really low risk change so hopefully should be an easy one to click merge on

I'm afraid I no longer have that level of access (and I'm also not a CODEREVIEWER).

A @pinterest/pymemcache person will need to step in.

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yurushao
Copy link
Contributor

yurushao commented Feb 5, 2025

The Lint step also failed on master branch. Probably not related to this PR.

@cclauss
Copy link
Contributor

cclauss commented Feb 5, 2025

black --check .
would reformat pymemcache/client/base.py

@daveisfera
Copy link
Contributor Author

black --check .
would reformat pymemcache/client/base.py

Pushed a commit to apply the change that black wanted

@jparise jparise merged commit 7e01ae2 into pinterest:master Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants