Add environment variable REDIS_PASSWORD#370
Open
mrolli wants to merge 1 commit intopinterest:masterfrom
Open
Conversation
This change allows to set a password without the need to build up a REDIS_URL environment variable. Fixes pinterest#369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to set a Redis password without the need to build up a whole REDIS_URL environment variable. The change is backward compatible as the default is set to "None", which is the default for redis.StrictRedis() according to the documentation.
With this change, deployment in a container app on Azure using a add-on Redis is then super simple as the env vars REDIS_HOST, REDIS_PORT and REDIS_PASSWORD are injected automatically by the platform.
Fixes #369