tl installer / new OpenOCD #149
Conversation
* Added missing UM boards and fixed TinyS3 product URL. Signed-off-by: Seon Rozenblum <[email protected]> * More modifications for UM boards. Signed-off-by: Seon Rozenblum <[email protected]> --------- Signed-off-by: Seon Rozenblum <[email protected]> Co-authored-by: Seon Rozenblum <[email protected]>
causes more issues than it solves.
Changed wrong board name Espressif ESP32-S3-DevKitC-1-N16R8V (16 MB Flash Quad, 16 MB PSRAM Octal)
* Update README.md to fix typo * Update README.md
WalkthroughThis update introduces several enhancements and refinements to the Espressif32 PlatformIO integration. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PlatformIO
participant Espressif32Platform
participant ToolInstaller (tl-install)
participant PackageManager
User->>PlatformIO: Initiate build/upload/debug
PlatformIO->>Espressif32Platform: Call configure_default_packages()
Espressif32Platform->>Espressif32Platform: Check debug/upload requirements
alt Debug or upload protocol required
Espressif32Platform->>ToolInstaller: Run install_tool for openocd/gdb
ToolInstaller->>PackageManager: Install/activate tool package
end
Espressif32Platform-->>PlatformIO: Configuration complete
Possibly related PRs
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (2)
platform.json (1)
152-169: Consistency check – duplicate “tool” classification already implied by key name.Setting
"type": "tool"is harmless, but it is redundant for packages whose name already starts withtool-…. Removing the field would shrink the manifest slightly and avoid maintenance noise.examples/arduino-blink/platformio.ini (1)
46-46: Minor formatting nit – extraneous spaces before ‘=’.
custom_component_add = …contains multiple spaces before the equals sign, whereas all other keys use a single space.
This has no functional impact but hurts consistency with the rest of the file.-custom_component_add = espressif/cmake_utilities @ 0.* +custom_component_add = espressif/cmake_utilities @ 0.*
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
examples/arduino-blink/platformio.ini(2 hunks)platform.json(4 hunks)platform.py(4 hunks)
🔇 Additional comments (3)
platform.json (2)
86-97: Confirm the change to always-install tooling (tool-esptoolpy,tl-install).Marking these tools as non-optional increases the minimal package footprint for every build.
Please double-check that (a) all supported workflows truly need them and (b) the referenced ZIP URLs are immutable and permanent; otherwise end-users may suddenly face ‟package not found” errors.If the tools are only required for selected scenarios (e.g. IDF-based projects), consider keeping them optional and letting
platform.pyforce-enable them on demand (similar totool-openocd-esp32).
107-109: New owner / custom binary fortool-openocd-esp32– please verify license and trust chain.The package now points to a custom build hosted under
pioarduino/registry.
Because OpenOCD is security-sensitive, ensure the binary is built from upstream sources without additional patches that could impact debugging reliability or introduce vulnerabilities.examples/arduino-blink/platformio.ini (1)
95-95: Good addition – explicitbuild_type = debugThis clarifies the intent for the C6 example and ties in nicely with the new conditional tool-installation logic.
Nothing to change here.
Description:
follow up of #148 for branch develop33
Checklist:
Summary by CodeRabbit