fix debug cfg

[Jason2866]

Description:

correct regression from platform.py refactoring

@mhaberler please try branch develop after merge.

Checklist:

• The pull request is done against the latest develop branch
• Only relevant files were touched
• Only one feature/fix was added per PR, more changes are allowed when changing boards.json
• I accept the CLA

Summary by CodeRabbit

• Bug Fixes
  • Updated debug server configuration to specify OpenOCD configuration file paths without the .cfg extension, improving compatibility with certain setups.

[coderabbitai]

Walkthrough

The change updates the _get_debug_server_args method within the Espressif32Platform class in platform.py. The method now omits the .cfg file extension from the second -f argument when constructing the OpenOCD debug server arguments, altering the way configuration file paths are specified.

Changes

Cohort / File(s)	Change Summary
OpenOCD Debug Server Argument Update platform.py	Modified _get_debug_server_args to remove .cfg extension from the second -f argument, changing config file path formatting.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Espressif32Platform
    participant OpenOCD

    User->>Espressif32Platform: Request debug server args
    Espressif32Platform->>Espressif32Platform: Build args (omit .cfg from config path)
    Espressif32Platform->>OpenOCD: Launch with updated args

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~6 minutes

Poem

In the land of code, a tweak so sly,
A ".cfg" vanished, none ask why.
Debug paths shorter, neat and trim,
The server starts with vigor and vim.
Hop, hop, hooray, the change is done—
The platform’s lighter, let’s have some fun! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d1be01 and 9af408d.

📒 Files selected for processing (1)

• platform.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: Jason2866
PR: pioarduino/platform-espressif32#246
File: builder/main.py:0-0
Timestamp: 2025-08-05T11:47:41.756Z
Learning: In the ESP32 platform builder, subprocess calls correctly use the virtual environment Python by explicitly passing PYTHON_EXE (which is set to the venv python path) as the first argument in the command array, rather than relying on environment variable propagation. The env=os.environ parameter only affects environment variables, not the executable path itself.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

• GitHub Check: build (windows-latest, examples/espidf-storage-sdcard)
• GitHub Check: build (windows-latest, examples/arduino-blink)
• GitHub Check: build (windows-latest, examples/tasmota)
• GitHub Check: build (windows-latest, examples/arduino-rmt-blink)
• GitHub Check: build (windows-latest, examples/espidf-arduino-blink)
• GitHub Check: build (windows-latest, examples/arduino-NimBLE-ext_client)
• GitHub Check: build (windows-latest, examples/arduino-zigbee-switch)
• GitHub Check: build (windows-latest, examples/arduino-wifiscan)
• GitHub Check: build (ubuntu-latest, examples/espidf-storage-sdcard)
• GitHub Check: build (windows-latest, examples/arduino-usb-keyboard)
• GitHub Check: build (windows-latest, examples/espidf-hello-world)
• GitHub Check: build (ubuntu-latest, examples/espidf-arduino-blink)
• GitHub Check: build (ubuntu-latest, examples/espidf-ulp)
• GitHub Check: build (ubuntu-latest, examples/espidf-arduino-littlefs)
• GitHub Check: build (ubuntu-latest, examples/espidf-arduino-matter-light)
• GitHub Check: build (ubuntu-latest, examples/espidf-blink)
• GitHub Check: build (ubuntu-latest, examples/arduino-NimBLE-ext_client)
• GitHub Check: build (ubuntu-latest, examples/espidf-exceptions)
• GitHub Check: build (ubuntu-latest, examples/arduino-blink)
• GitHub Check: build (ubuntu-latest, examples/espidf-hello-world)

🔇 Additional comments (1)

platform.py (1)

877-877: LGTM! Correctly fixes the OpenOCD configuration file path.

This change properly removes the redundant .cfg extension from the OpenOCD configuration file path. OpenOCD automatically appends the .cfg extension when loading configuration files, so explicitly including it would cause OpenOCD to look for files like target/esp32.cfg.cfg instead of target/esp32.cfg.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_debug_cfg

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Jason2866]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.