Skip to content

Ensure packages are checked from penv #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 9, 2025
Merged

Ensure packages are checked from penv #253

merged 14 commits into from
Aug 9, 2025

Conversation

Jason2866
Copy link

@Jason2866 Jason2866 commented Aug 9, 2025

use full path for uv and pio.

Checklist:

  • The pull request is done against the latest develop branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR, more changes are allowed when changing boards.json
  • I accept the CLA

Summary by CodeRabbit

  • New Features
    • Added automatic installation of the "platformio" package with a minimum required version.
  • Bug Fixes
    • Improved reliability of Python tool execution by resolving and using the correct paths for uv and pio executables, ensuring compatibility across different environments.
  • Chores
    • Updated dependency installation commands to use the appropriate Python interpreter and streamlined environment handling.

Copy link

coderabbitai bot commented Aug 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change updates the way the uv and pio executables are located and invoked in the build system, explicitly resolving their paths relative to the Python interpreter directory. It also adds a minimum version requirement for the platformio package and adjusts subprocess calls to include the --python flag and remove explicit environment passing.

Changes

Cohort / File(s) Change Summary
Executable Path Resolution for uv and pio
builder/frameworks/espidf.py
All invocations of uv and pio now use explicit paths constructed from the Python executable directory, replacing reliance on system PATH or shutil.which. Quoting and Windows-specific handling (.exe) are included.
Python Dependency Management and Subprocess Adjustments
builder/main.py
Adds "platformio": ">=6.1.18" to Python dependencies. Subprocess calls for installing and listing Python packages now use the --python flag with the virtual environment Python executable and omit the explicit environment variable argument.

Sequence Diagram(s)

sequenceDiagram
    participant Builder
    participant PythonEnv
    participant uv
    participant pio

    Builder->>PythonEnv: Get Python executable path
    Builder->>uv: Resolve uv executable path (from Python dir)
    Builder->>uv: Run 'uv pip list/install' with --python flag
    Builder->>pio: Resolve pio executable path (from Python dir)
    Builder->>pio: Run pio commands using explicit path
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • call esptool with full path #226: Also modifies how tool executables are resolved, focusing on esptool path resolution.
  • Full uv path #227: Directly addresses the explicit resolution and invocation of the uv executable, closely related to these changes.

Poem

A bunny hopped through Python’s lair,
Seeking tools with utmost care.
No more guessing in the PATHy night—
Now uv and pio are found just right!
With dependencies clear and subprocesses tight,
The build hops forward, light and bright.
🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop_path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jason2866
Copy link
Author

@coderabbitai full review

Copy link

coderabbitai bot commented Aug 9, 2025

✅ Actions performed

Full review triggered.

@Jason2866 Jason2866 merged commit 355f503 into develop Aug 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant