Skip to content

Update reassembly_queue to RFC 9260#414

Open
philipch07 wants to merge 2 commits intomasterfrom
pch07/update-reassembly_queue-9260
Open

Update reassembly_queue to RFC 9260#414
philipch07 wants to merge 2 commits intomasterfrom
pch07/update-reassembly_queue-9260

Conversation

@philipch07
Copy link
Contributor

@philipch07 philipch07 commented Oct 30, 2025

Description

Updates reassembly_queue to RFC 9260.

Also implements the todo regarding improved performance by using maps.

Requires #390 to be completed first so we can test this out and make sure it works correctly.

Reference issue

Resolves #415.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.94%. Comparing base (a69c6a2) to head (380ec62).

Files with missing lines Patch % Lines
reassembly_queue.go 93.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   83.84%   83.94%   +0.09%     
==========================================
  Files          51       51              
  Lines        3448     3475      +27     
==========================================
+ Hits         2891     2917      +26     
  Misses        417      417              
- Partials      140      141       +1     
Flag Coverage Δ
go 83.94% <93.33%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk requested a review from Copilot October 30, 2025 19:51
@philipch07 philipch07 force-pushed the pch07/update-reassembly_queue-9260 branch from efdf4bc to 558b595 Compare October 30, 2025 19:52

This comment was marked as outdated.

@JoTurk JoTurk requested a review from Copilot October 30, 2025 20:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

reassembly_queue.go:1

  • The documentation is misleading. A single-chunk unfragmented message can have both beginningFragment=1 and endingFragment=1 simultaneously, as evidenced by the code at lines 248-250 that handles this case. The comment should clarify that for multi-fragment messages, the first has beginningFragment=1, endingFragment=0, the last has beginningFragment=0, endingFragment=1, and for single-chunk messages both flags are 1.
// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@philipch07 philipch07 force-pushed the pch07/update-reassembly_queue-9260 branch 3 times, most recently from 6864609 to 52da5c8 Compare October 30, 2025 20:22
@philipch07 philipch07 force-pushed the pch07/update-reassembly_queue-9260 branch from 52da5c8 to 380ec62 Compare November 2, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update reassembly_queue.go to RFC 9260

2 participants