Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 83.84% 83.94% +0.09%
==========================================
Files 51 51
Lines 3448 3475 +27
==========================================
+ Hits 2891 2917 +26
Misses 417 417
- Partials 140 141 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efdf4bc to
558b595
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
reassembly_queue.go:1
- The documentation is misleading. A single-chunk unfragmented message can have both
beginningFragment=1andendingFragment=1simultaneously, as evidenced by the code at lines 248-250 that handles this case. The comment should clarify that for multi-fragment messages, the first hasbeginningFragment=1, endingFragment=0, the last hasbeginningFragment=0, endingFragment=1, and for single-chunk messages both flags are 1.
// SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6864609 to
52da5c8
Compare
52da5c8 to
380ec62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates reassembly_queue to RFC 9260.
Also implements the todo regarding improved performance by using maps.
Requires #390 to be completed first so we can test this out and make sure it works correctly.
Reference issue
Resolves #415.