Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 83.84% 83.94% +0.10%
==========================================
Files 51 51
Lines 3448 3470 +22
==========================================
+ Hits 2891 2913 +22
Misses 417 417
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for optional fields in SCTP reconfiguration response parameters according to RFC 6525. The implementation now handles the optional Sender's Next TSN and Receiver's Next TSN fields that were previously not supported.
- Added support for optional
senderNextTSNandreceiverNextTSNfields inparamReconfigResponse - Implemented marshaling and unmarshaling logic to handle variable-length parameter values (8, 12, or 16 bytes)
- Added validation to ensure
receiverNextTSNis only present whensenderNextTSNis present
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| param_reconfig_response.go | Extended struct with optional fields, updated marshal/unmarshal to handle variable lengths, added validation and new error types |
| param_reconfig_response_test.go | Added comprehensive tests for optional fields including roundtrip tests, validation tests, and renamed existing test function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
29ed51d to
aeb9ded
Compare
aeb9ded to
898ffcd
Compare
Description
Reference issue
Resolves #418.