Open
Conversation
This reverts commit 096446a.
philipch07
force-pushed
the
pch07/update-packet-to-rfc-9260
branch
from
4d51282 to
a8e9a70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 83.81% 84.00% +0.18%
==========================================
Files 51 51
Lines 3447 3450 +3
==========================================
+ Hits 2889 2898 +9
+ Misses 421 414 -7
- Partials 137 138 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 096446a, where it was reverted temporarily since it caused some checksum issues due to the rest of SCTP not being in line with RFC 9260 (essentially we should merge all the changes at once instead of piece by piece).
See previous PR body
Description
Note: The chunk test is modified since it uses packets, which has changed.
Reference issue
A part of #402. Split from #406.