Skip to content

Remove ic2 from ice-options #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Remove ic2 from ice-options #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions jsep.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,7 @@ func (s *SessionDescription) WithValueAttribute(key, value string) *SessionDescr
// WithICETrickleAdvertised advertises ICE trickle support in the session description.
// See https://datatracker.ietf.org/doc/html/rfc9429#section-5.2.1
func (s *SessionDescription) WithICETrickleAdvertised() *SessionDescription {
s.WithValueAttribute(AttrKeyICEOptions, "trickle ice2")

return s
return s.WithValueAttribute(AttrKeyICEOptions, "trickle")
}

// WithFingerprint adds a fingerprint to the session description.
Expand Down
2 changes: 1 addition & 1 deletion jsep_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func TestSessionDescriptionAttributes(t *testing.T) {
sd = sd.WithICETrickleAdvertised()
assert.Len(t, sd.Attributes, 3)
assert.Equal(t, AttrKeyICEOptions, sd.Attributes[2].Key)
assert.Equal(t, "trickle ice2", sd.Attributes[2].Value)
assert.Equal(t, "trickle", sd.Attributes[2].Value)
})

t.Run("WithFingerprint", func(t *testing.T) {
Expand Down
Loading