Conversation
sforward
commented
Feb 24, 2025
sforward
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ✔️ |
| Fixed issues | - |
|
@pionl have to approve this changes. |
| "illuminate/filesystem": "5.2 - 5.8 | ^6.0 | ^7.0 | ^8.0 | ^9.0 | ^10.0 | ^11.0 | ^12.0" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "5.7 | 6.0 | 7.0 | 7.5 | 8.4 | ^8.5 | ^9.3 | ^10.0 | ^11.0", |
There was a problem hiding this comment.
Should you add the phpunit/phpunit package (version ^12.0)?
There was a problem hiding this comment.
That version is also possible but not required to run the tests for Laravel 12.
|
@pionl please merge, everyone is waiting |
|
@pionl can you review and merge ? |
|
ya se tardaron |
|
@sforward thank you for the update. All tests passed. ❯ node tests.js "12.*" 🚀 Running tests for 12.* image version: 8.2-node-20 🚀 Running tests for 12.* image version: 8.3-node-22 🚀 Running tests for 12.* image version: 8.4-node-22 🎉 All tests passed |
6 participants
