Fix: Hide version selector on Home page and make v1 default#6480
Conversation
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
|
@eeshaanSA, PTAL when you have time : ) |
|
@eeshaanSA, there is one more thing I noticed. On smaller screens (phones), the version selector is not visible, so users currently have no way to change the version. Earlier users landed on v0.55, but after this PR they will land on v1 docs by default. However, on mobile they still won’t be able to switch versions since the selector is hidden. After we get this PR is merged, I’ll open a separate issue for this. |
eeshaanSA
left a comment
There was a problem hiding this comment.
@rahulshendre, while workflows are being run, can you provide a detailed screen recording of the change? Sorry for the trouble, but we do not have a live preview.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6480 +/- ##
==========================================
- Coverage 28.87% 26.19% -2.68%
==========================================
Files 560 16 -544
Lines 59955 1668 -58287
==========================================
- Hits 17313 437 -16876
+ Misses 41321 1194 -40127
+ Partials 1321 37 -1284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sure @eeshaanSA v1_defualt.mov |
What this PR does:
docs-v1.0Why we need it:
Homepage was showing a different version than the docs due to hardcoded selector and as v1 is going to be the latest version, we need it to be the default.
Which issue(s) this PR fixes:
Fixes #6478