[ECS-Plugin] Implement ECS_ SYNC stage

[armistcxy]

What this PR does:
Implementing ECS_SYNC stage. The quick sync and sync option will use this stage by default

Why we need it:

Which issue(s) this PR fixes: Part of #6443

Fixes #

Does this PR introduce a user-facing change?:

• How are users affected by this change:
• Is this breaking change:
• How to migrate (if breaking change):

[armistcxy]

There some works still needed to do before merging, I 've just created this PR so you (@khanhtc1202) can have a quick glance and give early feedbacks ^ ^

To make it easy when reviewing PR, you can refer to these resources:

• DeepWiki: ECS_SYNC stage
• ECS Executor Code (V0)

Some changes have been made (different from v0)

1. No longer check PipCD managed tags for service: Change
2. Check service's health status before update service: Check
3. Remove redundant slice copy in client.ListTags

func (c *client) ListTags(ctx context.Context, resourceArn string) ([]types.Tag, error) {
	input := &ecs.ListTagsForResourceInput{
		ResourceArn: aws.String(resourceArn),
	}

	output, err := c.ecsClient.ListTagsForResource(ctx, input)
	if err != nil {
		return nil, err
	}

	tags := make([]types.Tag, 0, len(output.Tags))
	for _, t := range output.Tags {
		tags = append(tags, types.Tag{
			Key:   t.Key,
			Value: t.Value,
		})
	}
	return tags, nil
}

TODO (in works):

• Figure out how to implement test for sync stage -> use mock for testing (logic-focus only, not real integrated) add unit test for sync function
• Figure out how to support other properties/fields for tasks and services (currently only supports v0-compatible props)

[armistcxy]

About the testing part, I've already made something like this to allow real integration test. But this is not safe due to potential waste if not handle cleaning up resources properly after test, maybe mocking will be better here

	var (
		clusterARN   = os.Getenv("ECS_CLUSTER_ARN")
		subnetIDsStr = os.Getenv("SUBNET_IDS")
		sgIDsStr     = os.Getenv("SECURITY_GROUP_IDS")

		subnetIDs []string
		sgIDs     []string
	)

	if clusterARN == "" {
		t.Skip("ECS_CLUSTER_ARN is not set, skipping ECS sync stage test")
	}
	if subnetIDsStr == "" {
		t.Skip("SUBNET_IDS is not set, skipping ECS sync stage test")
	}
	for _, id := range strings.Split(subnetIDsStr, ",") {
		subnetIDs = append(subnetIDs, strings.TrimSpace(id))
	}
	if len(subnetIDs) == 0 {
		t.Skip("SUBNET_IDS is empty, skipping ECS sync stage test")
	}
	if sgIDsStr == "" {
		t.Skip("SECURITY_GROUP_IDS is not set, skipping ECS sync stage test")
	}

[khanhtc1202]

For DetermineVersion function, I think you can ignore it in this PR, we can implement it by a separated PR

[khanhtc1202]

Also, your commits had shown as Unverified currently, could you check this docs and update Github setting to fix that
https://docs.github.com/en/authentication/managing-commit-signature-verification/displaying-verification-statuses-for-all-of-your-commits
Probably, this is caused by Github SSH Key is not being used

[khanhtc1202]

How about to move in inside LoadServiceDefinition function? Since we may need to do the same when implement rollout stage.

[armistcxy]

I think LoadServiecDefinition purpose is parsing manifest into types.Service, adding tags here I just feel not the right place to do that

[armistcxy]

IMO, adding tags explicitly in execute stage function will avoid confusion for the maintain work in the future

Also, LoadServiceDefinition current input consists of 2 params: appDir, serviceDefinition string, if moving adding tags to this function, we need to add pipeId, applicationId, commitHash, which will make the function bloat and drift away from its function

[khanhtc1202]

Okay, let re-check the service tags value of service object fetched from API when we update service. If it contains the tags as well, we can safely move this tag assign logic to load service definition, ensure service object in data flow will always have the tags. 👍
For now, let's keep the implementation as your 👍

[armistcxy]

The service returned from UpdateService API doesn't contain tags but all the stage use applyServiceDefinition and inside that function the tags are re assigned

// Re-assign tags to service object because UpdateService API doesn't return tags.
service.Tags = serviceDefinition.Tags

And my bad, the v0 loadServiceDefinition already add the tags inside

func loadServiceDefinition(in *executor.Input, serviceDefinitionFile string, ds *deploysource.DeploySource) (types.Service, bool) {
	in.LogPersister.Infof("Loading service manifest at commit %s", ds.Revision)

	serviceDefinition, err := provider.LoadServiceDefinition(ds.AppDir, serviceDefinitionFile)
	if err != nil {
		in.LogPersister.Errorf("Failed to load ECS service definition (%v)", err)
		return types.Service{}, false
	}

	serviceDefinition.Tags = append(
		serviceDefinition.Tags,
		provider.MakeTags(map[string]string{
			provider.LabelManagedBy:   provider.ManagedByPiped,
			provider.LabelPiped:       in.PipedConfig.PipedID,
			provider.LabelApplication: in.Deployment.ApplicationId,
			provider.LabelCommitHash:  in.Deployment.CommitHash(),
		})...,
	)

	in.LogPersister.Infof("Successfully loaded the ECS service definition at commit %s", ds.Revision)
	return serviceDefinition, true
}

Update:

// LoadServiceDefinition returns Service object from a given service definition file.
func LoadServiceDefinition(appDir, serviceDefinition string, input *sdk.ExecuteStageInput[config.ECSApplicationSpec]) (types.Service, error) {
	path := filepath.Join(appDir, serviceDefinition)
	service, err := loadServiceDefinition(path)
	if err != nil {
		return types.Service{}, err
	}
	// Add PipeCD-managed tags
	service.Tags = append(service.Tags,
		MakeTags(map[string]string{
			LabelManagedBy:   ManagedByECSPlugin,
			LabelPiped:       input.Request.Deployment.PipedID,
			LabelApplication: input.Request.Deployment.ApplicationID,
			LabelCommitHash:  input.Request.TargetDeploymentSource.CommitHash,
		})...,
	)
	return service, nil
}

[armistcxy]

Resolved with chore: move add pipecd-related tags to load service function

[khanhtc1202]

LGTM 💯