Optimize PatternPairAggregator with incremental parsing#3607
Open
KYash03 wants to merge 3 commits intopipecat-ai:mainfrom
Open
Optimize PatternPairAggregator with incremental parsing#3607KYash03 wants to merge 3 commits intopipecat-ai:mainfrom
KYash03 wants to merge 3 commits intopipecat-ai:mainfrom
Conversation
Contributor
|
This change is pretty significant. Is there any way to make it more narrowly focused on this?
|
Author
|
I've trimmed the diff to remove unrelated changes. The core change is replacing regex-based re.finditer scanning (O(n²)) with incremental delimiter detection (O(n)) — that's inherently a full rewrite of the matching logic, so the diff can't get much smaller without artificially splitting it into separate PRs. Happy to do that if you'd prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the regex loop in PatternPairAggregator with a single-pass parser. It’s significantly faster and consumes less memory. Verified backward compatibility with existing tests!