gemini-live: end response segment before running tool calls#3609
Open
KartikVashishta wants to merge 1 commit intopipecat-ai:mainfrom
Open
gemini-live: end response segment before running tool calls#3609KartikVashishta wants to merge 1 commit intopipecat-ai:mainfrom
KartikVashishta wants to merge 1 commit intopipecat-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #3552,
Gemini Live pauses generation while a tool call is outstanding and does (may) not emit turn_complete until tool responses are provided. If a tool returns run_llm=False and ends the task, we could keep the bot marked as responding and defer EndFrame indefinitely.
Close out the current response segment before dispatching tool calls (clear buffers, stop TTS when appropriate, emit LLMFullResponseEndFrame) so EndFrame can propagate and the pipeline shuts down cleanly