fix(smallwebrtc): respect audio_out_10ms_chunks parameter in RawAudioTrack#3645
Open
fix(smallwebrtc): respect audio_out_10ms_chunks parameter in RawAudioTrack#3645
Conversation
…Track The RawAudioTrack class was hardcoded to always produce 10ms audio frames regardless of the audio_out_10ms_chunks transport parameter. This caused firmware clients to receive 20ms chunks even when 40ms was configured. Changes: - Add num_10ms_chunks parameter to RawAudioTrack constructor - Update add_audio_bytes to chunk audio based on configured size - Update recv() to produce frames of the configured size - Pass audio_out_10ms_chunks from TransportParams when creating track
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where SmallWebRTCTransport was ignoring the audio_out_10ms_chunks parameter from TransportParams, always producing 10ms audio frames instead of respecting the configured chunk size (e.g., 40ms for audio_out_10ms_chunks=4).
Changes:
- Added
num_10ms_chunksparameter toRawAudioTrackclass with proper calculation of chunk sizes - Updated validation and frame generation logic to respect configurable chunk sizes
- Modified track instantiation to pass through the configured parameter from
TransportParams
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pipecat/transports/smallwebrtc/transport.py | Modified RawAudioTrack to accept and respect num_10ms_chunks parameter, updating initialization, validation, and frame generation logic to support configurable audio chunk sizes |
| changelog/3645.fixed.md | Added changelog entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensure num_10ms_chunks is a positive integer to prevent division by zero or invalid audio chunk sizes. Raises ValueError if value is less than 1.
Contributor
|
Requesting that @filipi87 take a look at this one when he has a moment. |
… guard) Migrate from pytest-style to unittest.IsolatedAsyncioTestCase to match the pattern used by other transport tests (e.g. test_livekit_transport.py). Guard the aiortc/av import with try/except and skipUnless so tests gracefully skip when webrtc dependencies aren't installed. Add pyright suppressions for false positives inherent to testing internals of optional-dependency classes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
@filipi87 I went through line by line and this all looks right to me, however my SmallWebRTC Vibe isn't strong enough to 100% confirm 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue where
SmallWebRTCTransportwas not respecting theaudio_out_10ms_chunksparameter fromTransportParams. TheRawAudioTrackclass was hardcoded to always produce 10ms audio frames, causing firmware clients to receive incorrect chunk sizes (e.g., receiving 20ms chunks when 40ms was configured).Problem
When using
SmallWebRTCTransporton Pipecat Cloud withaudio_out_10ms_chunks=4(40ms), firmware clients were still receiving 20ms audio chunks. This happened because:audio_out_10ms_chunksRawAudioTrackin SmallWebRTC was re-chunking the audio back to 10ms for WebRTC transmissionrecv()method always produced 10ms frames regardless of configurationSolution
Updated
RawAudioTrackto accept and respect a configurable chunk size:num_10ms_chunksparameter toRawAudioTrackconstructor (default 1 for backward compatibility)add_audio_bytes()to validate and chunk audio using the configured chunk sizerecv()to produce audio frames of the configured size and advance timestamps correctly_handle_client_connected()to passaudio_out_10ms_chunksfromTransportParamswhen creating the trackTesting
audio_out_10ms_chunks=4now correctly produces 40ms audio frames over WebRTC