Prevent deadlock when pipeline task is cancelled#4061
Draft
audricschiltknecht wants to merge 1 commit intopipecat-ai:mainfrom
Draft
Prevent deadlock when pipeline task is cancelled#4061audricschiltknecht wants to merge 1 commit intopipecat-ai:mainfrom
audricschiltknecht wants to merge 1 commit intopipecat-ai:mainfrom
Conversation
Author
|
As posted in discord, I'm not linking the fix here as it leaves lot of dangling tasks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logic of PipelineTask::_process_push_queue inside a try/except asyncio.CancelledError.
Try to cleanup the pipeline when it is cancelled.
Fixes #3929