Open
Conversation
Contributor
|
Thanks for this! I've tested it and I still don't think the previous incomplete segments are getting included in the complete inference. For example, see the following example where the "complete" segment is shorter than the "incomplete" segment (which means the "incomplete" must have been discarded). |
Author
|
@marcus-daily You are right. The speech active flag is also impacting how the buffer accumulates. I will update this PR soon. |
Author
|
@marcus-daily I have added a turn flag in addition to the vad/active flag. Here is part of my local testing logs: I have left some printing statements in for now so you can also test it. I will clean them up before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes sure the segment is only cleared after a positive turn detection. This should address the issue mentioned in #25 (comment)