Note added on reason for FullControl scope for sharepoint.#101
Note added on reason for FullControl scope for sharepoint.#101R0gue-one wants to merge 2 commits intopipeshub-ai:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a note to the SharePoint connector documentation, explaining the necessity of specific permission scopes ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request adds a valuable note to the SharePoint connector documentation, clarifying the necessity of Sites.FullControl.All and Files.ReadWrite.All permissions. This significantly improves user understanding during the configuration process.
|
|
||
| <Note> | ||
| **Permission Requirements:** | ||
| * Although the connector only performs read operations, `Sites.FullControl.All` is strictly required by the SharePoint API to fetch granular site group permissions. |
There was a problem hiding this comment.
The phrase 'only performs read operations' in the first bullet point could be slightly misleading given that Files.ReadWrite.All is required for webhook subscriptions, which involves write operations. Changing 'only performs' to 'primarily performs' would improve accuracy and prevent potential confusion.
* While the connector primarily performs read operations for data syncing, `Sites.FullControl.All` is strictly required by the SharePoint API to fetch granular site group permissions.
No description provided.