Skip to content

Note added on reason for FullControl scope for sharepoint.#101

Open
R0gue-one wants to merge 2 commits intopipeshub-ai:mainfrom
R0gue-one:shrapoint-scopes-update
Open

Note added on reason for FullControl scope for sharepoint.#101
R0gue-one wants to merge 2 commits intopipeshub-ai:mainfrom
R0gue-one:shrapoint-scopes-update

Conversation

@R0gue-one
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a note to the SharePoint connector documentation, explaining the necessity of specific permission scopes (Sites.FullControl.All and Files.ReadWrite.All) for the connector to function correctly. This clarification helps users understand the permission requirements and avoid potential issues.

Highlights

  • Permission Requirements: A note was added to explain why Sites.FullControl.All is required by the SharePoint API, even though the connector only performs read operations. It's needed to fetch granular site group permissions.
  • Webhook Subscriptions: The note also clarifies that Files.ReadWrite.All is required by the Microsoft Graph API to establish and renew webhook subscriptions for document libraries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a valuable note to the SharePoint connector documentation, clarifying the necessity of Sites.FullControl.All and Files.ReadWrite.All permissions. This significantly improves user understanding during the configuration process.


<Note>
**Permission Requirements:**
* Although the connector only performs read operations, `Sites.FullControl.All` is strictly required by the SharePoint API to fetch granular site group permissions.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'only performs read operations' in the first bullet point could be slightly misleading given that Files.ReadWrite.All is required for webhook subscriptions, which involves write operations. Changing 'only performs' to 'primarily performs' would improve accuracy and prevent potential confusion.

* While the connector primarily performs read operations for data syncing, `Sites.FullControl.All` is strictly required by the SharePoint API to fetch granular site group permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant