feat(evmengine): use current finalized block events & remove prev events#514
Draft
jdubpark wants to merge 6 commits intorelease/1.2from
Draft
feat(evmengine): use current finalized block events & remove prev events#514jdubpark wants to merge 6 commits intorelease/1.2from
jdubpark wants to merge 6 commits intorelease/1.2from
Conversation
jdubpark
force-pushed
the
jdub/use-finalized-events
branch
from
049d709 to
ddccb9c
Compare
jdubpark
added
enhancement
0xHansLee
reviewed
Mar 14, 2025
| option (cosmos.msg.v1.signer) = "authority"; | ||
| string authority = 1; | ||
| bytes execution_payload = 2; | ||
| repeated EVMEvent prev_payload_events = 3; |
Contributor
There was a problem hiding this comment.
Please mark reserve or deprecated, not removing the field for future backward or forward compatibility.
It can cause unexpected issue in deserialization.
https://stackoverflow.com/questions/71782502/what-happened-if-you-delete-a-field-on-protobuf
limengformal
force-pushed
the
release/1.2
branch
from
8c010fa to
77804f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove prev EL block events in CL block. Instead, fetch & use finalized EL block's events after CL block is finalized.
issue: none