Draft
Conversation
ramtinms
reviewed
Feb 6, 2026
| bytes32 expectedCodeCommitment, | ||
| bytes32 expectedDataCommitment, | ||
| bytes calldata enclaveReport, | ||
| bytes calldata validationContext |
There was a problem hiding this comment.
what is validation context? is it params needed for passing to automata?
Contributor
Author
There was a problem hiding this comment.
it's arbitrary data depending on each enclave type - for SGX is the tbcEvalNumber. When not needed can pass empty
0xHansLee
reviewed
Feb 9, 2026
Contributor
|
The changes you've made looks good to me. Can you resolve the failed gha by changing the title of PR and write body of PR with footer (issue: none)? Also please change the base branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.