feat(config)!: Add enviroment variables interpolation for env_{KEY}#546
Merged
feat(config)!: Add enviroment variables interpolation for env_{KEY}#546
Conversation
5K1PY
added
high priority
SvizelPritula
requested changes
Dec 2, 2025
| result[-1][-1] += char | ||
| elif char == "\\": | ||
| result.append(["escape", ""]) | ||
| elif val[i : i + 2] == "${": |
Contributor
There was a problem hiding this comment.
Why do character escapes use an intermediate state while this looks two characters ahead?
pisek/config/task_config.py
Outdated
| ) | ||
|
|
||
| def interpolate(key: str, val: str) -> str: | ||
| result: list[list[str]] = [["normal", ""]] |
Contributor
There was a problem hiding this comment.
Is a parser state really a homogenous sequence of strings of variable length?
If this is the result, why isn't it returned?
5K1PY
force-pushed
the
feat/env-interpolation
branch
from
7ed8c64 to
a73389a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540