Skip to content

Solution visuals improvments#551

Merged
5K1PY merged 4 commits intomasterfrom
feat/solution-visuals-improv
Dec 6, 2025
Merged

Solution visuals improvments#551
5K1PY merged 4 commits intomasterfrom
feat/solution-visuals-improv

Conversation

@5K1PY
Copy link
Collaborator

@5K1PY 5K1PY commented Dec 6, 2025

No description provided.

@5K1PY 5K1PY requested a review from SvizelPritula December 6, 2025 09:42
@5K1PY 5K1PY self-assigned this Dec 6, 2025
Comment on lines +24 to +25
def check_verdicts(
verdicts: list[Verdict], expected: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function in very hard to understand, with a loop where each iteration is nearly completely different.

Copy link
Contributor

@SvizelPritula SvizelPritula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check_verdicts method is hard to understand, but otherwise ok.

@5K1PY 5K1PY force-pushed the feat/solution-visuals-improv branch from 2ba3c3d to 251299e Compare December 6, 2025 17:21
@5K1PY 5K1PY merged commit ccacd3c into master Dec 6, 2025
2 checks passed
@5K1PY 5K1PY deleted the feat/solution-visuals-improv branch December 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants