Skip to content

fix(config): A bit looser program names #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5K1PY merged 1 commit into from
Feb 22, 2026
Merged

fix(config): A bit looser program names #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/config-v3-documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ These can be basic:
- False values: `0`, `False`, `false`, `f`, `no`, `n`, `off`
- enum — One of the values specified in the key description.
- 'string literal'
- run_ref — String referencing a [`[run]`](#run) section. Must match the regex `[A-Za-z][A-Za-z0-9/_-]*`.
- build_ref — String referencing a [`[build]`](#build) section. Must match the regex `[A-Za-z][A-Za-z0-9/_-]*`.
- run_ref — String referencing a [`[run]`](#run) section. Must match the regex `[A-Za-z0-9][A-Za-z0-9./_^+-]*`.
- build_ref — String referencing a [`[build]`](#build) section. Must match the regex `[A-Za-z0-9][A-Za-z0-9./_^+-]*`.

!!! info
Through auto-expansion and auto-generation run_ref and build_ref values can interpreted as paths.
Expand Down
2 changes: 1 addition & 1 deletion pisek/config/task_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def _validate_program_name(key: str, value: str) -> str:
)
for char in value:
# Be careful, the hyphen has to be last
if not re.fullmatch("[A-Za-z0-9./_-]", char):
if not re.fullmatch("[A-Za-z0-9./_^+-]", char):
raise PydanticCustomError(
f"invalid_{error_key}",
f"{key.capitalize()} must not contain '{char}'",
Expand Down