fix(build): Do not copy target to Cargo's build directory#640
Merged
Conversation
pisek/jobs/jobs.py
Outdated
| files = sorted( | ||
| file | ||
| for file in glob.glob(g, recursive=True, include_hidden=True) | ||
| if all(not os.path.commonpath([exc, file]) == exc for exc in exclude) |
Contributor
There was a problem hiding this comment.
Can't this use TaskPath.is_prefix?
pisek/jobs/cache.py
Outdated
| envs: list[tuple[str, ...]] | ||
| files: list[str] | ||
| globs: list[str] | ||
| globs: list[tuple[str, tuple[str, ...]]] |
Contributor
There was a problem hiding this comment.
I don't think the meaning of globs is clear at all.
pisek/jobs/jobs.py
Outdated
| for g in sorted(globs): | ||
| glob_sign = f"{g} -> " + " ".join( | ||
| glob.glob(g, recursive=True, include_hidden=True) | ||
| for g, exclude in sorted(globs): |
Contributor
There was a problem hiding this comment.
Couldn't this share code with _globs_to_files?
SvizelPritula
approved these changes
Feb 22, 2026
Contributor
SvizelPritula
left a comment
SvizelPritula
left a comment
There was a problem hiding this comment.
LGTM, that is much better.
5K1PY
force-pushed
the
fix/rust-target
branch
from
20f513c to
db34b4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593