Display invalid markers in a separate sidebar#127
Display invalid markers in a separate sidebar#127mbilker wants to merge 10 commits intopittcsc:masterfrom
Conversation
vonbearshark
left a comment
vonbearshark
left a comment
There was a problem hiding this comment.
Code looks good, but there doesn't seem to be any unmapped right now? What's that?
index.html
Outdated
| </footer> | ||
| </div> | ||
| <div id="unmappedRecords"> | ||
| <h3>Invalid Entries</h3> |
There was a problem hiding this comment.
Maybe we should call this "Unmapped Records" here, too. Seems more intuitive UX
There was a problem hiding this comment.
I do agree that is better.
|
I only saw some unmapped police records, but maybe they are older than 30 days now. |
|
Should I add a media query to hide the unmapped records section on mobile? |
|
Also, should I make the unmapped records section hideable? |
|
Ideally it should behave just like the other sidebar: shown as closed on mobile with a button to expand/contract on both mobile and desktop |
This allows the filtering methods to not care about recomputing the contents of a list cell for an unmapped record.
mbilker
force-pushed
the
display-invalid-markers
branch
from
f798d2b to
81858ab
Compare
…arkers * upstream/master: Better-looking data table on mobile Merge with hideControls, small desktop fix Hide controls in adata-tab mode (desktop only)
|
@vonbearshark I see that the |
|
cc @seifriedc ^^ |
|
An array? An array of what exactly? The Also, is this ready? |
|
@vonbearshark The I was thinking it could return: |
|
@mbilker Are you initial commits associated with "displaying invalid markers in a separate sidebar" ready? If so I can merge this PR and we can worry about returning an array of elements for the table in an issue (I think that's where that problem should go). In that issue, please detail what we would gain from returning an array of elements like you propose. |
…arkers * upstream/master: small word changes to about page made the 3rd paragraph of the about this project more vague Created rough draft of about page; feel free to add to this Jumpstarted the about page for issue pittcsc#65 Added extra statement to enforce the 'month' button changes to white Added functionality to allow users to change the default view of the application to month, week, or day; shipped with week as default Added to documentation about changing default checkboxes for including in an external site Added functionality so users can choose the default ticked checkboxes Added notification animation Removed vanish css (for PR) Adjusted button positioning Remove feedback button Add feedback link Add feedback button Big overhaul. MVP for TPN integration
3 participants
Currently, invalid entries from the data sources are stored without
marker.pinand never displayed through a check thatmarker.isMapped === true.This PR proposes to display these markers in a separate sidebar on the right side. The design of the entry display in this new sidebar is not final, but the code to display the entries in the sidebar is working.