Skip to content

Fix pytest warnings #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drdavella merged 2 commits into from
Mar 4, 2025
Merged

Fix pytest warnings #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff415c
fix pythonjsonlogger warning
clavedeluna Feb 25, 2025
39dabe7
warn to warning
clavedeluna Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/codemodder/codemods/regex_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def _apply(self, original_lines, file_context, results):
changed_line = self._apply_regex(line)
updated_lines.append(changed_line)
if line == changed_line:
logger.warn("Unable to update html line: %s", line)
logger.warning("Unable to update html line: %s", line)
self.report_unfixed(
file_context,
one_idx_lineno,
Expand Down
4 changes: 2 additions & 2 deletions src/codemodder/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from enum import Enum
from typing import Generator, Optional

from pythonjsonlogger import jsonlogger
from pythonjsonlogger import json

logger = logging.getLogger("codemodder")

Expand All @@ -21,7 +21,7 @@ def __str__(self):
return self.value.lower()


class CodemodderJsonFormatter(jsonlogger.JsonFormatter):
class CodemodderJsonFormatter(json.JsonFormatter):
project_name: Optional[str]

def __init__(self, *args, project_name: Optional[str] = None, **kwargs):
Expand Down
4 changes: 2 additions & 2 deletions tests/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from pythonjsonlogger import jsonlogger
from pythonjsonlogger import json

from codemodder.logging import OutputFormat, configure_logger

Expand All @@ -10,7 +10,7 @@ def test_json_logger(mocker):
assert basic_config.call_args[1]["format"] == "%(message)s"
assert isinstance(
basic_config.call_args[1]["handlers"][0].formatter,
jsonlogger.JsonFormatter,
json.JsonFormatter,
)
assert (
basic_config.call_args[1]["handlers"][0].formatter.project_name
Expand Down
Loading