Skip to content

SarifResult class should not be abstract #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drdavella merged 2 commits into from
Mar 27, 2025
Merged

SarifResult class should not be abstract #1032

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f44a0f9
SarifResult class should not be abstract
drdavella Mar 26, 2025
cd899da
Add finding message extraction
drdavella Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/codemodder/result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ class SASTResult(Result):


@dataclass(frozen=True, kw_only=True)
class SarifResult(SASTResult, ABCDataclass):
class SarifResult(SASTResult):
finding_msg: str | None = None
location_type: ClassVar[Type[SarifLocation]]

@classmethod
Expand All @@ -119,12 +120,17 @@ def from_sarif(
url=cls.rule_url_from_id(sarif_result, sarif_run, rule_id),
),
),
finding_msg=cls.extract_finding_message(sarif_result, sarif_run),
)

@classmethod
@abstractmethod
def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str:
raise NotImplementedError
def extract_finding_message(cls, sarif_result: dict, sarif_run: dict) -> str | None:
return sarif_result.get("message", {}).get("text", None)

@classmethod
def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str | None:
del result, run, rule_id
return None

@classmethod
def extract_locations(cls, sarif_result) -> Sequence[Location]:
Expand Down
Loading